Skip to content

FIX: stop supporting strange pandas#22128

Closed
jklymak wants to merge 1 commit into
matplotlib:mainfrom
jklymak:fix-dont-use-check-1d
Closed

FIX: stop supporting strange pandas#22128
jklymak wants to merge 1 commit into
matplotlib:mainfrom
jklymak:fix-dont-use-check-1d

Conversation

@jklymak

@jklymak jklymak commented Jan 6, 2022

Copy link
Copy Markdown
Member

PR Summary

Mostly reverts #16347. Probably missing some edge cases...

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@jklymak

jklymak commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

... of course it fails the units tests...

@jklymak jklymak closed this Jan 6, 2022
@jklymak jklymak deleted the fix-dont-use-check-1d branch January 6, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant