Skip to content

FIX: squash memory leak in colorbar #22089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 2 commits into from
Jan 4, 2022
Merged

FIX: squash memory leak in colorbar #22089

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20ce53
FIX: squash memory leak in colorbar
jklymak Jan 3, 2022
c151e71
Fix list creation
jklymak Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/matplotlib/colorbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,10 +1410,13 @@ def make_axes(parents, location=None, orientation=None, fraction=0.15,
anchor = kwargs.pop('anchor', loc_settings['anchor'])
panchor = kwargs.pop('panchor', loc_settings['panchor'])
aspect0 = aspect
# turn parents into a list if it is not already. We do this w/ np
# because `plt.subplots` can return an ndarray and is natural to
# pass to `colorbar`.
parents = np.atleast_1d(parents).ravel()
# turn parents into a list if it is not already. Note we cannot
# use .flatten or .ravel as these copy the references rather than
# reuse them, leading to a memory leak
if isinstance(parents, np.ndarray):
parents = list(parents.flat)
elif not isinstance(parents, list):
parents = [parents]
fig = parents[0].get_figure()

pad0 = 0.05 if fig.get_constrained_layout() else loc_settings['pad']
Expand Down Expand Up @@ -1461,8 +1464,8 @@ def make_axes(parents, location=None, orientation=None, fraction=0.15,
# tell the parent it has a colorbar
a._colorbars += [cax]
cax._colorbar_info = dict(
location=location,
parents=parents,
location=location,
shrink=shrink,
anchor=anchor,
panchor=panchor,
Expand Down Expand Up @@ -1586,6 +1589,7 @@ def make_axes_gridspec(parent, *, location=None, orientation=None,
fraction=fraction,
aspect=aspect0,
pad=pad)

return cax, kwargs


Expand Down