Skip to content

Keep FontEntry helpers private. #22042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 1 commit into from
Dec 23, 2021
Merged

Keep FontEntry helpers private. #22042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/matplotlib/font_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def findSystemFonts(fontpaths=None, fontext='ttf'):
return [fname for fname in fontfiles if os.path.exists(fname)]


def fontentry_helper_repr_png_(fontent):
def _fontentry_helper_repr_png(fontent):
from matplotlib.figure import Figure # Circular import.
fig = Figure()
font_path = Path(fontent.fname) if fontent.fname != '' else None
Expand All @@ -392,8 +392,8 @@ def fontentry_helper_repr_png_(fontent):
return buf.getvalue()


def fontentry_helper_repr_html_(fontent):
png_stream = fontentry_helper_repr_png_(fontent)
def _fontentry_helper_repr_html(fontent):
png_stream = _fontentry_helper_repr_png(fontent)
png_b64 = b64encode(png_stream).decode()
return f"<img src=\"data:image/png;base64, {png_b64}\" />"

Expand All @@ -414,8 +414,8 @@ def fontentry_helper_repr_html_(fontent):

It is used when populating the font lookup dictionary.
""",
'_repr_html_': lambda self: fontentry_helper_repr_html_(self),
'_repr_png_': lambda self: fontentry_helper_repr_png_(self),
'_repr_html_': lambda self: _fontentry_helper_repr_html(self),
'_repr_png_': lambda self: _fontentry_helper_repr_png(self),
}
)

Expand Down