Skip to content

Added docstring to rrulewrapper class - #21993

Merged
timhoffm merged 4 commits into
mainfrom
unknown repository
Dec 21, 2021
Merged

timhoffm merged 4 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Dec 17, 2021

Copy link
Copy Markdown

@StefRe

StefRe commented Dec 17, 2021

Copy link
Copy Markdown
Contributor

hm, the docstring alone doesn't appear to have any effect - see here and here.

Comment thread lib/matplotlib/dates.py Outdated
class rrulewrapper:
"""
A simple wrapper around a ``dateutil.rrule`` allowing almost
arbitrary date tick specifications.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "allowing flexible date tick ...".

@tacaswell tacaswell added this to the v3.6.0 milestone Dec 17, 2021

@dstansby dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks like it's failing our flake8 tests. Could you fix this? It looks like there just a blank line that needs deleting.

@ghost

ghost commented Dec 21, 2021

Copy link
Copy Markdown
Author

@dstansby Thanks for the hint!

@timhoffm
timhoffm merged commit b57506e into matplotlib:main Dec 21, 2021
@ghost
ghost deleted the add_rrulewrapper_docstring branch December 22, 2021 07:31
@oscargus oscargus mentioned this pull request May 14, 2022
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants