-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
DOC: remove experimental tag from CL #21975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note I also adjusted the |
bd740ce to
3a4c0fb
Compare
dstansby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With an optional suggestion
lib/matplotlib/figure.py
Outdated
| layout managers can have significant performance penalties as | ||
| they require an extra draw and solve an inverse problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| layout managers can have significant performance penalties as | |
| they require an extra draw and solve an inverse problem. | |
| layout managers can have significant performance penalties. |
For brevity, I don't think we need to explain why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm weakly in favor of brevity here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done...
tacaswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3a4c0fb to
8cbe67e
Compare
PR Summary
Constrained layout is not really experimental any more, and we probably should not break it at this point....
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).