Skip to content

Fix ConciseDateFormatter offset during zoom - #21785

Merged
QuLogic merged 2 commits into
matplotlib:mainfrom
jklymak:fix-concise-offset-zoom
Nov 29, 2021
Merged

QuLogic merged 2 commits into
matplotlib:mainfrom
jklymak:fix-concise-offset-zoom

Conversation

@jklymak

@jklymak jklymak commented Nov 28, 2021

Copy link
Copy Markdown
Member

PR Summary

Closes #21670

When plotting > 1year with concisedateformatter, no offset text is shown,. However, when you zoom it should be shown. However, we were hard-fixing the parameter for the locator, and it didn't reset itself. This PR fixes the zooming and adds a test to fix this.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@dstansby dstansby added this to the v3.5.1 milestone Nov 28, 2021
@jklymak jklymak changed the title Fix concise offset zoom Fix ConciseDateFormatter offset during zoom Nov 29, 2021
@jklymak jklymak added PR: bugfix Pull requests that fix identified bugs topic: date handling labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: bugfix Pull requests that fix identified bugs topic: date handling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ConciseDateFormatter not showing offset

3 participants