FIX: manual colorbars and tight layout #21751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
added
topic: color/colorbar
topic: geometry manager
QuLogic
approved these changes
Nov 26, 2021
jklymak
force-pushed
the
fix-manual-colorbar-tight
branch
from
cd1135c to
98cd347
Compare
dstansby
approved these changes
Nov 28, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 28, 2021
dstansby
added a commit
that referenced
this pull request
Nov 28, 2021
…751-on-v3.5.x Backport PR #21751 on branch v3.5.x (FIX: manual colorbars and tight layout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #21749
The subplotsepc logic was not correct for manually added colorbars so that tight_layout would raise instead of warn about the manual colorbar not being part of a layout.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).