FIX: logic of title repositioning#21398
Conversation
|
This PR is affected by a re-writing of our history to remove a large number of accidentally committed files see discourse for details. To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote git remote update
git checkout main
git merge --ff-only upstream/main
git checkout YOUR_BRANCH
git rebase --onto=main upstream/old_master
# git rebase -i main # if you prefer
git push --force-with-lease # assuming you are tracking your branchIf you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you. Thank you for your contributions to Matplotlib and sorry for the inconvenience. |
12b6012 to
b0d9f30
Compare
|
... rebased |
dstansby
left a comment
There was a problem hiding this comment.
Should get an API/behaviour change not, but looks 👍
timhoffm
left a comment
There was a problem hiding this comment.
I'm undecided if this really needs an API change note. IMHO pure bugfixes don't need if the original behavior is obviously wrong and nobody will depend on it.
greglucas
left a comment
There was a problem hiding this comment.
I think this is good to go and was not changing expected behavior as evidenced by the linked bug report.
PR Summary
Addresses #21394 so that the padding is consistent, if not exactly what the user wants.
Old
Note how when we sharex the title is displaced downwards, but only in the first plot, not the last one. This is inconsistent with the sharex=False behaviour, which is to manually move the axes outside the axes bounds (regardless of the users' pad argument).
We did discuss this behaviour, and decided it was OK, if less than great. Users can get around this by specifying
ymanually (i.e.y=1.0001works fine). We probably should deprecate thepadargument in favour of just asking folks to specify the title position usingy.New
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).