Skip to content

Make Path.__deepcopy__ interact better with subclasses, e.g. TextPath. #21280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 1 commit into from
Oct 7, 2021
Merged

Make Path.__deepcopy__ interact better with subclasses, e.g. TextPath. #21280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/matplotlib/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,10 @@ def __deepcopy__(self, memo=None):
Return a deepcopy of the `Path`. The `Path` will not be
readonly, even if the source `Path` is.
"""
try:
codes = self.codes.copy()
except AttributeError:
codes = None
return self.__class__(
self.vertices.copy(), codes,
_interpolation_steps=self._interpolation_steps)
# Deepcopying arrays (vertices, codes) strips the writeable=False flag.
p = copy.deepcopy(super(), memo)
p._readonly = False
return p

deepcopy = __deepcopy__

Expand Down
10 changes: 10 additions & 0 deletions lib/matplotlib/tests/test_textpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import copy

from matplotlib.textpath import TextPath


def test_copy():
tp = TextPath((0, 0), ".")
assert copy.deepcopy(tp).vertices is not tp.vertices
assert (copy.deepcopy(tp).vertices == tp.vertices).all()
assert copy.copy(tp).vertices is tp.vertices