Skip to content

Remove dummy test command from setup.py #21059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstansby merged 1 commit into from
Sep 12, 2021
Merged

Remove dummy test command from setup.py #21059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from setuptools import setup, find_packages, Extension
import setuptools.command.build_ext
import setuptools.command.build_py
import setuptools.command.test
import setuptools.command.sdist

from distutils.errors import CompileError
Expand Down Expand Up @@ -67,12 +66,6 @@ def has_flag(self, flagname):
return True


class NoopTestCommand(setuptools.command.test.test):
def __init__(self, dist):
print("Matplotlib does not support running tests with "
"'python setup.py test'. Please run 'pytest'.")


class BuildExtraLibraries(setuptools.command.build_ext.build_ext):
def finalize_options(self):
self.distribution.ext_modules[:] = [
Expand Down Expand Up @@ -341,7 +334,6 @@ def make_release_tree(self, base_dir, files):
"fallback_version": "0.0+UNKNOWN",
},
cmdclass={
"test": NoopTestCommand,
"build_ext": BuildExtraLibraries,
"build_py": BuildPy,
"sdist": Sdist,
Expand Down