Skip to content

Support marker="none" to mean "no marker". - #21055

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:mn
Sep 14, 2021
Merged

jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:mn

Conversation

@anntzer

@anntzer anntzer commented Sep 12, 2021

Copy link
Copy Markdown
Contributor

As for other APIs (#19300), this is less likely to be confused with the None
object.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added the API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … label Sep 12, 2021
Comment on lines +3 to +4
... to mean "no-marker", consistently with other APIs which support the
lowercase version.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
... to mean "no-marker", consistently with other APIs which support the
lowercase version.
... to mean *no-marker*, consistently with other APIs which support the
lowercase version. Using 'none' is recommended over using 'None'.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread lib/matplotlib/markers.py Outdated
``10`` (``CARETUPBASE``) |m35| caretup (centered at base)
``11`` (``CARETDOWNBASE``) |m36| caretdown (centered at base)
``"None"``, ``" "`` or ``""`` nothing
``"None"`` or ``"None"`` nothing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean:

Suggested change
``"None"`` or ``"None"`` nothing
``"none"`` or ``"None"`` nothing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes.

As for other APIs, this is less likely to be confused with the None
object.
@jklymak
jklymak merged commit 8c2a65d into matplotlib:master Sep 14, 2021
@anntzer
anntzer deleted the mn branch September 14, 2021 11:38
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Support marker="none" to mean "no marker".
@QuLogic QuLogic added this to the v3.6.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, …

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants