Don't add 1 to all hexbin data when using log norm #21038
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
hexbin-log
branch
from
c8690fd to
2034ccf
Compare
Member
|
What is the git blame for that? It'd be interesting to see the reasoning. |
Contributor
|
This came in in 5f8a88a back in 2010, and I guess logzero handling was more iffy back then. |
Member
Author
|
It goes all the way back to 2010: 5f8a88a. I'm not sure what the motivation for it was, but perhaps handling zero values on a log norm didn't work as well back then? |
dstansby
force-pushed
the
hexbin-log
branch
from
2034ccf to
72ab6ac
Compare
Member
Author
|
I'm closing this in favour of #21039 which has more fixes, to avoid changing a test image twice. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This seems very wrong - it means that every bin that doesn't actually have a data point turns up with a value of 1, and all other bins have a value of 1 added to them. We handle the case where the bin value = 0 and a log scale fine by just not showing the bin.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).