changed URL to the current CSV API for yahoo finance #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
added a commit
that referenced
this pull request
May 29, 2013
changed URL to the current CSV API for yahoo finance
mdboom
added a commit
that referenced
this pull request
May 29, 2013
changed URL to the current CSV API for yahoo finance
mdboom
added a commit
that referenced
this pull request
May 29, 2013
changed URL to the current CSV API for yahoo finance
Member
|
@mdboom - backported to v1.2.x? |
Member
|
Yep. Might as well have the URL work there, too. |
Contributor
Author
|
thanks guys |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a example on clustering was not working in scikit-learn and tracked it back to a yahoo CSV api url in finance.py of matplotlib being out of date. I looked around yahoo's documentation and it appears that their base url has changed to
http://table.finance.yahoo.com/table.csv
to
http://ichart.yahoo.com/table.csv