Repository navigation
Fix leak if affine_transform is passed invalid vertices. - #20645
Merged
Merged
Conversation
anntzer
approved these changes
Jul 17, 2021
anntzer
left a comment
Contributor
There was a problem hiding this comment.
modulo the minor point above being addressed (or explicitly rejected)
timhoffm
approved these changes
Jul 17, 2021
QuLogic
force-pushed
the
fix-path-affine-leak
branch
from
July 19, 2021 19:49
eab7f55 to
8c0d73e
Compare
Member
|
Feel free to self-merge when CI is done! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 19, 2021
…invalid vertices.
QuLogic
added a commit
that referenced
this pull request
Jul 20, 2021
…645-on-v3.4.x Backport PR #20645 on branch v3.4.x (Fix leak if affine_transform is passed invalid vertices.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
CALL_CPPmay raise an exception, so we should drop theverticesref before calling it. We've already added an automatically-dropping ref with thearray_view, so we don't need this one.Fixes #20641.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).