Skip to content

Fix leak if affine_transform is passed invalid vertices. - #20645

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
QuLogic:fix-path-affine-leak
Jul 19, 2021
Merged

QuLogic merged 1 commit into
matplotlib:masterfrom
QuLogic:fix-path-affine-leak

Conversation

@QuLogic

@QuLogic QuLogic commented Jul 14, 2021

Copy link
Copy Markdown
Member

PR Summary

CALL_CPP may raise an exception, so we should drop the vertices ref before calling it. We've already added an automatically-dropping ref with the array_view, so we don't need this one.

Fixes #20641.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.4.3 milestone Jul 14, 2021

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo the minor point above being addressed (or explicitly rejected)

Comment thread src/_path_wrapper.cpp Resolved
@QuLogic
QuLogic force-pushed the fix-path-affine-leak branch from eab7f55 to 8c0d73e Compare July 19, 2021 19:49
@jklymak

jklymak commented Jul 19, 2021

Copy link
Copy Markdown
Member

Feel free to self-merge when CI is done!

@QuLogic
QuLogic merged commit 246a489 into matplotlib:master Jul 19, 2021
@QuLogic
QuLogic deleted the fix-path-affine-leak branch July 19, 2021 20:46
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 19, 2021
QuLogic added a commit that referenced this pull request Jul 20, 2021
…645-on-v3.4.x

Backport PR #20645 on branch v3.4.x (Fix leak if affine_transform is passed invalid vertices.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak in function matplotlib._path.affine_transform

4 participants