Skip to content

Backport PR #20584: FIX: do not simplify path in LineCollection.get_s… - #20587

Merged
jklymak merged 1 commit into
matplotlib:v3.4.xfrom
tacaswell:auto-backport-of-pr-20584-on-v3.4.x
Jul 6, 2021
Merged

jklymak merged 1 commit into
matplotlib:v3.4.xfrom
tacaswell:auto-backport-of-pr-20584-on-v3.4.x

Conversation

@tacaswell

Copy link
Copy Markdown
Member

…egments

Merge pull request #20584 from tacaswell/fix_linecollection_simplified_segments

FIX: do not simplify path in LineCollection.get_segments
Conflicts:
lib/matplotlib/tests/test_collections.py
- only backport the new test

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

…tion.get_segments

Merge pull request matplotlib#20584 from tacaswell/fix_linecollection_simplified_segments

FIX: do not simplify path in LineCollection.get_segments
Conflicts:
	lib/matplotlib/tests/test_collections.py
         - only backport the new test
@tacaswell tacaswell added this to the v3.4.3 milestone Jul 6, 2021
@jklymak

jklymak commented Jul 6, 2021

Copy link
Copy Markdown
Member

I don't think this needs to run the docs to prove it is working...

@jklymak
jklymak merged commit 171f055 into matplotlib:v3.4.x Jul 6, 2021
@tacaswell
tacaswell deleted the auto-backport-of-pr-20584-on-v3.4.x branch July 6, 2021 23:32
@tacaswell

Copy link
Copy Markdown
Member Author

This may have set a land-speed record for getting a PR reviewed, merged, and backported! (never mind it sat un-committed on my computer for almost a week....)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants