Skip to content

backend_gtk: don't hide FileChooserDialog; closes #1530 - #2056

Merged
mdboom merged 2 commits into
matplotlib:v1.2.xfrom
efiring:gtk_filechooser_no_hide
May 24, 2013
Merged

mdboom merged 2 commits into
matplotlib:v1.2.xfrom
efiring:gtk_filechooser_no_hide

Conversation

@efiring

@efiring efiring commented May 23, 2013

Copy link
Copy Markdown
Member

Hiding the FileChooserDialog was pointless, because a
new one is created each time the Save Figure button is
clicked in the Toolbar. Hiding seems to have prevented
the widget from being destroyed based on refcount, and this
led to heavy access to the recently-used.xbel file with
every subsequent keystroke.

efiring added 2 commits May 23, 2013 11:27
Hiding the FileChooserDialog was pointless, because a
new one is created each time the Save Figure button is
clicked in the Toolbar.  Hiding seems to have prevented
the widget from being destroyed based on refcount, and this
led to heavy access to the recently-used.xbel file with
every subsequent keystroke.
@pelson

pelson commented May 24, 2013

Copy link
Copy Markdown
Member

👍 from me. I'm willing to merge this provided we can check that it hasn't had cross platform adverse affects in the release candidate. I propose we explicitly ask for release candidate testers to reply to the RC announcement with their OS, python version, numpy version and backends tested.

@mdboom

mdboom commented May 24, 2013

Copy link
Copy Markdown
Member

Yeah -- I agree. Let's get this in the release candidate to give it lots of testing, and fix or revert as necessary before the final release.

mdboom added a commit that referenced this pull request May 24, 2013
backend_gtk: don't hide FileChooserDialog; closes #1530
@mdboom
mdboom merged commit d6c6afd into matplotlib:v1.2.x May 24, 2013
@mdboom

mdboom commented May 28, 2013

Copy link
Copy Markdown
Member

@efiring: Unfortunately, it now appears that the file save dialog never goes away. It saves the file, but the dialog remains open and responsive after clicking the Save button. This is on Fedora 18. Can you confirm on your system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants