Repository navigation
Pathing issue - #20395
Pathing issue#20395
Conversation
e0cbad6 to
81a3cff
Compare
| b = transform.transform_path(Path([(0, 1), (0, 2), (0, 5)])) | ||
| assert a.intersects_path(b) and b.intersects_path(a) | ||
|
|
||
| # test added to adress issue #20328 |
There was a problem hiding this comment.
Can you say what #20328 was? This code may outlive GitHub and this comment won't be helpful...
There was a problem hiding this comment.
Good suggestion, I rewrote the comments to be more alike the ones already present in the tests.
jklymak
left a comment
There was a problem hiding this comment.
Aside from the nit about the comment...
|
Thanks @diegopetrola! |
|
Did you not want this backported? |
|
(me? I'm fine if we back port, but didn't think it was a regression...) |
|
Yes, you milestoned the closed issue for 3.4.3. |
|
@meeseeksdev backport to 3.4.3 |
|
Something went wrong ... Please have a look at my logs. It seem that the branch you are trying to backport to does not exists. |
|
@meeseeksdev backport to 3.4.x |
|
Something went wrong ... Please have a look at my logs. It seem that the branch you are trying to backport to does not exists. |
|
@meeseeksdev backport to v3.4.x |
…395-on-v3.4.x Backport PR #20395 on branch v3.4.x (Pathing issue)
* added check for collinearity
PR Summary
PR Checklist
Closes #20328
What I did:
I will wait for the automated checks to pass before asking for a review.
Edit: ready for review.