Fix cursor with toolmanager on GTK3.#20273
Merged
Merged
Conversation
This was broken in matplotlib#19441 because toolmanager uses a fake version of the toolbar2 class which doesn't have any static (or otherwise) methods.
anntzer
approved these changes
May 21, 2021
Member
Author
|
I tried to add tests for this, but apparently #17986 makes this impossible. |
timhoffm
approved these changes
May 23, 2021
Member
|
Merging without test. We can always add one if we find out how to. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This was broken in #19441 because toolmanager uses a fake version of the toolbar2 class which doesn't have any static (or otherwise) methods.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).