Skip to content

Update span_selector.py - #20212

Merged
timhoffm merged 2 commits into
matplotlib:masterfrom
Jashshah6086:master
May 16, 2021
Merged

timhoffm merged 2 commits into
matplotlib:masterfrom
Jashshah6086:master

Conversation

@Jashshah6086

@Jashshah6086 Jashshah6086 commented May 12, 2021 •

Copy link
Copy Markdown
Contributor

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@Jashshah6086

Copy link
Copy Markdown
Contributor Author

Updated span_selector and all checks passed

@jklymak

jklymak commented May 13, 2021

Copy link
Copy Markdown
Member

Can you explain a bit more in the PR description what this does and why? Was this example broken before?

@jklymak jklymak added the status: needs clarification Issues that need more information to resolve. label May 13, 2021
@jklymak
jklymak marked this pull request as draft May 13, 2021 14:00
@Jashshah6086

Copy link
Copy Markdown
Contributor Author

The example was not robust enough.
If the cursor was not drag it gave error in command line.
This was because the list was empty. So, added condition on the length of list(region_x) to prevent any error.

@QuLogic

QuLogic commented May 13, 2021

Copy link
Copy Markdown
Member

This is related to #20200; please give your PRs a summary as not everyone is going to remember and cross-reference every single issue.

@Jashshah6086

Copy link
Copy Markdown
Contributor Author

Okay, this is my first time contributing so didn't know.

@Jashshah6086
Jashshah6086 marked this pull request as ready for review May 14, 2021 08:03

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip for future pull requests: If you write "Closes #20200" this will link the PR to the issue and also automatically close the issue when the PR gets merged. See also Linking a pull request to an issue using a keyword

Comment thread examples/widgets/span_selector.py Resolved
@timhoffm timhoffm removed the status: needs clarification Issues that need more information to resolve. label May 15, 2021
Comment thread examples/widgets/span_selector.py Resolved
@timhoffm timhoffm added this to the v3.4.3 milestone May 16, 2021
@timhoffm
timhoffm merged commit 0554030 into matplotlib:master May 16, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 16, 2021
@timhoffm

Copy link
Copy Markdown
Member

Thanks @Jashshah6086! Congratulations on your first contribution to Matplotlib. We hope to see you again.

timhoffm added a commit that referenced this pull request May 16, 2021
…212-on-v3.4.x

Backport PR #20212 on branch v3.4.x (Update span_selector.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants