Repository navigation
Deprecate drawtype to RectangleSelector - #19934
Merged
Merged
Conversation
dstansby
force-pushed
the
drawtype
branch
3 times, most recently
from
April 11, 2021 09:30
98dd585 to
03455aa
Compare
timhoffm
approved these changes
Apr 11, 2021
QuLogic
approved these changes
Apr 13, 2021
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17473 for the behaviour of
drawtype='line', which is very odd and doesn't really work as a selector; @timhoffm suggested deprecating it in #17473 (comment), and I agree. Doing this will allow the internals ofRectangleSelectorto be greatly simplified, making it much easier for it to be modified in the future.At the same time,
drawtype='none'can just be achieved by making the rectangle invisible, so deprecatedrawtypealtogether.