Skip to content

Deprecate drawtype to RectangleSelector - #19934

Merged
QuLogic merged 2 commits into
matplotlib:masterfrom
dstansby:drawtype
Apr 13, 2021
Merged

QuLogic merged 2 commits into
matplotlib:masterfrom
dstansby:drawtype

Conversation

@dstansby

@dstansby dstansby commented Apr 10, 2021 •

Copy link
Copy Markdown
Member

See #17473 for the behaviour of drawtype='line', which is very odd and doesn't really work as a selector; @timhoffm suggested deprecating it in #17473 (comment), and I agree. Doing this will allow the internals of RectangleSelector to be greatly simplified, making it much easier for it to be modified in the future.

At the same time, drawtype='none' can just be achieved by making the rectangle invisible, so deprecate drawtype altogether.

@dstansby
dstansby force-pushed the drawtype branch 3 times, most recently from 98dd585 to 03455aa Compare April 11, 2021 09:30
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic
QuLogic merged commit f650bf8 into matplotlib:master Apr 13, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Apr 13, 2021
@dstansby
dstansby deleted the drawtype branch April 13, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants