Skip to content

FIX errorbar problem with fillstyle#19784

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
smartlixx:FIX_v3.4.0_errorbar_fillstyle
Mar 30, 2021
Merged

FIX errorbar problem with fillstyle#19784
QuLogic merged 1 commit into
matplotlib:masterfrom
smartlixx:FIX_v3.4.0_errorbar_fillstyle

Conversation

@smartlixx

@smartlixx smartlixx commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

PR Summary

close #19776.

I don't know if this is exactly the reason for the problem, but it can fix the reported problem.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak
jklymak reviewed Mar 27, 2021
View reviewed changes

@jklymak jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But we should make sure there is a test for this...

@jklymak jklymak added this to the v3.4.1 milestone Mar 27, 2021
@smartlixx smartlixx force-pushed the FIX_v3.4.0_errorbar_fillstyle branch 2 times, most recently from c186650 to c368596 Compare March 29, 2021 03:33
@smartlixx

smartlixx commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

Thanks! But we should make sure there is a test for this...

OK, a test has been added.

@smartlixx smartlixx requested a review from jklymak March 29, 2021 04:26
jklymak
jklymak reviewed Mar 29, 2021
View reviewed changes

@jklymak jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK? I guess I don't understand error bar adequately to say why this fixes the original problem, and the test doesn't really test the original problem? But I didn't spend any time on it.

QuLogic
QuLogic approved these changes Mar 29, 2021
View reviewed changes
Comment thread lib/matplotlib/tests/test_axes.py Outdated
@smartlixx smartlixx force-pushed the FIX_v3.4.0_errorbar_fillstyle branch from c368596 to 4b6f658 Compare March 30, 2021 01:22
@smartlixx

smartlixx commented Mar 30, 2021

Copy link
Copy Markdown
Contributor Author

Seems OK? I guess I don't understand error bar adequately to say why this fixes the original problem, and the test doesn't really test the original problem? But I didn't spend any time on it.

This problem was introduced in the commit 0782c74 (#17930), in which the way of plotting Line2D has been modified, and the eb_lines_style includes everything for both lines and markers. So it is necessary to pop up all markers-related kwargs in order to plot error bars.

@tacaswell

tacaswell commented Mar 30, 2021

Copy link
Copy Markdown
Member

Thanks @smartlixx !

@QuLogic QuLogic merged commit 2e25c66 into matplotlib:master Mar 30, 2021
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 30, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 30, 2021
@QuLogic @meeseeksmachine
Backport PR matplotlib#19784: FIX errorbar problem with fillstyle
56c53bd
QuLogic added a commit that referenced this pull request Mar 30, 2021
@QuLogic
Merge pull request #19818 from meeseeksmachine/auto-backport-of-pr-19…
315ff06 
…784-on-v3.4.x

Backport PR #19784 on branch v3.4.x (FIX errorbar problem with fillstyle)
@smartlixx smartlixx deleted the FIX_v3.4.0_errorbar_fillstyle branch March 30, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak left review comments

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.4.1

Development

Successfully merging this pull request may close these issues.

Errorbars with yerr fail when fillstyle is specified

4 participants

@smartlixx @tacaswell @QuLogic @jklymak