Skip to content

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 25, 2021

PR Summary

This deprecation is missing the addition/removal version, and it triggers an extra warning because it uses the old cbook.warn_deprecated.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.4.0 milestone Mar 25, 2021
@tacaswell
Copy link
Member

@QuLogic can self-merge when CI is green.

@QuLogic QuLogic merged commit dffe59f into matplotlib:v3.4.x Mar 26, 2021
@QuLogic QuLogic deleted the fix-imread-deprecation branch March 26, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants