Repository navigation
Correctly check inaxes for multicursor - #19636
Conversation
|
There are very few widget tests, so if you want to write one, that'd be great. |
dstansby
left a comment
There was a problem hiding this comment.
Thanks a lot for this! I've commented on what needs to change for the tests to pass. In addition, do you think you'll be able to add a new test to check for the bug that you've fixed? If not, I can have a go at adding one.
Hi @dstansby thanks for pinging me here. Work got busy, and it suddenty wasn't allllways below freezing so I've been making a concsious effort to be outside instead of on my computer and let this slip - sorry about that! Anyway I added a test which I think covers most what seems relevant for MultiCursor. |
|
Since this is a bugfix could it be re-milestoned to Apparently people are running into this, see #20231 |
|
@meeseeksdev backport to v3.4.x |
…636-on-v3.4.x Backport PR #19636 on branch v3.4.x (Correctly check inaxes for multicursor)
PR Summary
multicursor now checks if
event.inaxesis one of the axes it will draw on.Fixes: #19635
Before

After:
PR Checklist
There aren't any multicursor tests - does this change need a test?
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).