FIX: check for a set during color conversion #19583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
added
topic: color/color & colormaps
Release critical
jklymak
force-pushed
the
fix-check-set-colors
branch
from
ff8954c to
2f0219b
Compare
tacaswell
approved these changes
Feb 25, 2021
tacaswell
reviewed
Feb 25, 2021
jklymak
force-pushed
the
fix-check-set-colors
branch
2 times, most recently
from
851af74 to
9d99c53
Compare
Member
Author
|
@mwaskom did you have a second to check if this will work? Or at least that the tests cover the cases you think are important? |
|
My test suite passes with this change and the logic of the code looks right to me, thanks for asking. |
timhoffm
reviewed
Feb 27, 2021
Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
jklymak
force-pushed
the
fix-check-set-colors
branch
from
9d99c53 to
669c08a
Compare
QuLogic
approved these changes
Mar 1, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 1, 2021
QuLogic
added a commit
that referenced
this pull request
Mar 2, 2021
…583-on-v3.4.x Backport PR #19583 on branch v3.4.x (FIX: check for a set during color conversion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19544 using @anntzer suggested fix....