Skip to content

Fix text position with usetex and xcolor #19501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tacaswell merged 3 commits into from
Feb 17, 2021
Merged

Fix text position with usetex and xcolor #19501

tacaswell merged 3 commits into from
Feb 17, 2021

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 11, 2021

PR Summary

Applies the patch from @anntzer and adds a test
Fixes #19234.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/usetex labels Feb 11, 2021
@QuLogic QuLogic added this to the v3.4.0 milestone Feb 11, 2021
anntzer
anntzer reviewed Feb 15, 2021
View reviewed changes
timhoffm
timhoffm reviewed Feb 15, 2021
View reviewed changes
tacaswell
tacaswell reviewed Feb 16, 2021
View reviewed changes
@tacaswell
Copy link
Member

tacaswell commented Feb 17, 2021

This collides with the pgf PR that just went in :/

@tacaswell
Copy link
Member

tacaswell commented Feb 17, 2021

@QuLogic can self merge this if rebased and tests are green.

@tacaswell tacaswell merged commit 01d3149 into matplotlib:master Feb 17, 2021
@QuLogic QuLogic deleted the usetex-xcolor branch February 17, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm left review comments

@tacaswell tacaswell tacaswell approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/usetex

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

tick labels displaced vertically with text.usetex and xcolor

4 participants

@QuLogic @tacaswell @anntzer @timhoffm