Repository navigation
test for align_ylabel bug with constrained_layout - #19373
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
4d86764 to
9dd68a2
Compare
87a475b to
4b0ea8e
Compare
|
Can you rebase on latest |
4b0ea8e to
0a46886
Compare
0a46886 to
2ab0e05
Compare
|
No I don't think the issues are with this PR. Thanks a lot for your persistence and help! |
PR Summary
Checks for bug in which align_ylabel drives y labels of some subplots off the edge of the plot when using constrained layout under the circumstances laid out here: #19152 . This is my first contribution to open-source, so any feedback is helpful! On the first checklist item, I'm not sure what "pytest style unit tests" are in particular, and I'm having trouble getting the test suite to run at all, though I managed the first time I cloned the repository and my added test performed as it should have.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).