Fix sphinx search #19279
Merged
Fix sphinx search #19279
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx stopped loading language_data.js globally in 3.4. This file now has to be loaded explicitly on the search page. See - sphinx-doc/sphinx#8445 - readthedocs/sphinx_rtd_theme#1021
story645
approved these changes
Jan 12, 2021
Member
story645
left a comment
story645
left a comment
There was a problem hiding this comment.
Thanks for catching/fixing this! :)
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 12, 2021
QuLogic
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 12, 2021
timhoffm
added a commit
that referenced
this pull request
Jan 12, 2021
…279-on-v3.3.3-doc Backport PR #19279 on branch v3.3.3-doc (Fix sphinx search)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Search does not work on our current devdocs, which are built with Sphinx 3.4.x.
Reason / Solution
Sphinx stopped loading language_data.js globally in 3.4.
This file now has to be loaded explicitly on the search page.
See