Skip to content

Workaround for Python 3 with pyparsing <= 2.0.0 - #1927

Merged
mdboom merged 1 commit into
matplotlib:masterfrom
mdboom:pyparsing-workaround
May 13, 2013
Merged

mdboom merged 1 commit into
matplotlib:masterfrom
mdboom:pyparsing-workaround

Conversation

@mdboom

@mdboom mdboom commented Apr 19, 2013

Copy link
Copy Markdown
Member

Turning off packrat parsing will avoid a bug in pyparsing <= 2.0.0, however it is much slower.

http://pyparsing.svn.sourceforge.net/viewvc/pyparsing/src/pyparsing_py3.py?r1=219&r2=218&pathrev=219

This is a follow on to the discussion in #1788

@mdboom

mdboom commented Apr 19, 2013

Copy link
Copy Markdown
Member Author

In #1788, @juliantaylor suggested adding a test for the bug, rather than a strict version check. I thought it actually better to have a workaround, which is to turn off packrat parsing... It would be difficult to test for the case and then respond accordingly, since there is no function to disable packrat parsing once it is enabled. I think this at least allows people who fall in the hole of being on Python 3 but who want to install everything from dependencies to move forward with something that at least works.

mdboom added a commit that referenced this pull request May 13, 2013
Workaround for Python 3 with pyparsing <= 2.0.0
@mdboom
mdboom merged commit e13cd6e into matplotlib:master May 13, 2013
@mdboom
mdboom deleted the pyparsing-workaround branch August 7, 2014 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant