Repository navigation
Supported datetimes with microseconds, and those with long time series (>160 years). - #1925
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
Small typo: nonsigular => nonsingular
Member
Author
|
Thanks @NelleV - I've added a commit which addresses your comments. |
Member
|
LGTM 👍 for merge ! |
Member
Author
|
Thanks @efiring - I've done all of the above. The dates module is also now completely pep8 compliant. I think this is good to go. |
Member
|
There are some Travis failures here, but once those are resolved, I think this looks good. |
Member
Author
|
I've updated the failing test result (and removed the formats which are not exercising anything new). |
Member
Author
|
Again, I think this is good for merge. |
efiring
added a commit
that referenced
this pull request
May 20, 2013
Supported datetimes with microseconds, and those with long time series (>160 years).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the AutoDateLocator and AutoDateFormatter classes to handle extreme time series (
<1second and>160years).The follow code demonstrates the problems:
(try running this before this PR to see the improvement)