Repository navigation
Fix Artist.remove_callback() - #19180
Merged
Merged
Conversation
timhoffm
force-pushed
the
fix-artist-remove-callback
branch
from
December 28, 2020 00:09
add9cdb to
ad1d9a2
Compare
Member
|
Is there a good way to test for this (even if it's just adding a smoke test)? |
Regression was introduced in matplotlib#18912.
timhoffm
force-pushed
the
fix-artist-remove-callback
branch
2 times, most recently
from
December 28, 2020 20:25
977d051 to
ae46b11
Compare
Member
Author
|
Added a small test. |
dstansby
approved these changes
Dec 28, 2020
Member
|
@anntzer the regression was on your PR. Can you make sure this change is the right one? |
anntzer
approved these changes
Dec 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression was introduced in #18912.