Skip to content

Check that no new figures are created in image comparison tests - #19179

Merged
jklymak merged 3 commits into
matplotlib:masterfrom
dstansby:test_fig_check
Dec 29, 2020
Merged

jklymak merged 3 commits into
matplotlib:masterfrom
dstansby:test_fig_check

Conversation

@dstansby

@dstansby dstansby commented Dec 27, 2020 •

Copy link
Copy Markdown
Member

PR Summary

xref #18581. Perhaps this should be a warning instead to start with in case anyone else is using this function outside of MPL?

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@dstansby

Copy link
Copy Markdown
Member Author

😄 and to prove this is useful, it caught a test that was not plotting to the actual ref/test figures!

@dstansby
dstansby marked this pull request as ready for review December 28, 2020 22:35
@jklymak
jklymak merged commit d0f8f81 into matplotlib:master Dec 29, 2020
@jklymak jklymak added this to the v3.4.0 milestone Dec 29, 2020
@dstansby
dstansby deleted the test_fig_check branch December 29, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants