Repository navigation
Check that no new figures are created in image comparison tests - #19179
Merged
Merged
Conversation
dstansby
marked this pull request as draft
December 27, 2020 16:49
Member
Author
|
😄 and to prove this is useful, it caught a test that was not plotting to the actual ref/test figures! |
dstansby
marked this pull request as ready for review
December 28, 2020 22:35
timhoffm
approved these changes
Dec 28, 2020
jklymak
approved these changes
Dec 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
xref #18581. Perhaps this should be a warning instead to start with in case anyone else is using this function outside of MPL?
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).