Repository navigation
Add the ability to plot striped lines - #19053
Closed
lucielavigne wants to merge 2 commits into
Closed
lucielavigne wants to merge 2 commits into
lucielavigne wants to merge 2 commits into
Conversation
Member
|
Can you add a PR summary or mark as draft if you are not ready for review yet? |
timhoffm
reviewed
Dec 28, 2020
Member
There was a problem hiding this comment.
Thanks for the PR, and welcome to Matplotlib!
Things to do:
- The comments below.
- Please fix the formatting issues flake8 complains about.
- Add a PR summary.
Discussion:
I'm a bit worried that the term offcolor is too vague. Maybe something like dash_gap_color?
Comment on lines
+1069
to
+1070
| Set the offcolor of the line. | ||
| By default set at 'None' |
Member
There was a problem hiding this comment.
Suggested change
| Set the offcolor of the line. | |
| By default set at 'None' | |
| Set the gap color for the dashed line style. |
Comment on lines
+1074
to
+1075
| offcolor : color or None | ||
| """ |
Member
There was a problem hiding this comment.
Suggested change
| offcolor : color or None | |
| """ | |
| offcolor : color or None | |
| The gap color. If None, the gaps are unfilled. | |
| """ |
Member
|
@lucielavigne do you plan to continue working on this? |
jklymak
marked this pull request as draft
April 23, 2021 16:55
rcomer
added a commit
to rcomer/matplotlib
that referenced
this pull request
Jun 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).