Templatize class factories. - #19033
Merged
Merged
Conversation
anntzer
force-pushed
the
class-factories
branch
4 times, most recently
from
November 27, 2020 17:23
e6165b6 to
66de640
Compare
anntzer
force-pushed
the
class-factories
branch
from
December 8, 2020 22:14
66de640 to
fdfa893
Compare
jklymak
marked this pull request as draft
May 9, 2021 00:44
anntzer
marked this pull request as ready for review
May 9, 2021 09:42
Contributor
Author
|
rebased, should be good to go. |
anntzer
force-pushed
the
class-factories
branch
5 times, most recently
from
May 9, 2021 12:34
b12a53e to
788162d
Compare
Member
|
Since the song and dance was for cartopy do we know it works for them now? @dopplershift @QuLogic |
Contributor
|
Examples seem to run fine (and there are no new test failures) with this PR + CartoPy master. |
jklymak
approved these changes
May 12, 2021
QuLogic
reviewed
May 13, 2021
Contributor
Author
|
rebased |
anntzer
marked this pull request as ready for review
May 24, 2021 20:08
QuLogic
reviewed
May 25, 2021
jklymak
marked this pull request as draft
May 26, 2021 14:53
This makes mpl_toolkits axes classes picklable (see test_pickle) by generalizing the machinery of _picklable_subplot_class_constructor, which would otherwise have had to be reimplemented for each class factory.
Member
|
But I guess now that things have reasonable names, they're no longer linking in docs? |
Contributor
Author
|
Indeed, updated missing-references. |
QuLogic
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes mpl_toolkits axes classes picklable (see test_pickle) by
generalizing the machinery of _picklable_subplot_class_constructor,
which would otherwise have had to be reimplemented for each class
factory.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).