Skip to content

Use lambdas to prevent gc'ing and deduplication of widget callbacks. - #18923

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:wcb
Nov 11, 2020
Merged

QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:wcb

Conversation

@anntzer

@anntzer anntzer commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

This makes the behavior of widget callbacks more consistent with the old
behavior (of using strong refs), and also more consistent with other
widgets which don't rely on CallbackRegistry at all, such as
SpanSelector and Lasso.

See #18226 (comment).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This makes the behavior of widget callbacks more consistent with the old
behavior (of using strong refs), and also more consistent with other
widgets which don't rely on CallbackRegistry at all, such as
SpanSelector and Lasso.
@anntzer anntzer added this to the v3.4.0 milestone Nov 10, 2020
@QuLogic
QuLogic merged commit 02af61b into matplotlib:master Nov 11, 2020
@anntzer
anntzer deleted the wcb branch November 11, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants