Skip to content

Use CallbackRegistry for {Artist,Collection}.add_callback. - #18912

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:cbr
Nov 10, 2020
Merged

QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:cbr

Conversation

@anntzer

@anntzer anntzer commented Nov 7, 2020

Copy link
Copy Markdown
Contributor

... but wrap callbacks in lambdas to maintain the old semantics of never
using weakrefs and not dropping duplicates.

Same advantages as in #18226.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

... but wrap callbacks in lambdas to maintain the old semantics of never
using weakrefs and not dropping duplicates.
@QuLogic QuLogic added this to the v3.4.0 milestone Nov 10, 2020
@QuLogic
QuLogic merged commit b561849 into matplotlib:master Nov 10, 2020
@anntzer
anntzer deleted the cbr branch November 10, 2020 07:43
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Dec 27, 2020
Regression was introduced in matplotlib#18912.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Dec 28, 2020
Regression was introduced in matplotlib#18912.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Dec 28, 2020
Regression was introduced in matplotlib#18912.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Dec 28, 2020
Regression was introduced in matplotlib#18912.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants