Skip to content

Remove fallback to nonexistent setDevicePixelRatioF. - #18877

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:sdpr
Nov 5, 2020
Merged

Remove fallback to nonexistent setDevicePixelRatioF.#18877
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:sdpr

Conversation

@anntzer

@anntzer anntzer commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

setDevicePixelRatioF never existed, per #15656 (comment). I'll let @timhoffm sort out the situation wrt devicePixelRatioF :) (#15656 (comment))

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic

QuLogic commented Nov 4, 2020

Copy link
Copy Markdown
Member

CI says you missed something...

setDevicePixelRatioF never existed.
@anntzer

anntzer commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

oops

@QuLogic QuLogic added this to the v3.4.0 milestone Nov 5, 2020
@timhoffm
timhoffm merged commit eeef6e5 into matplotlib:master Nov 5, 2020
@anntzer
anntzer deleted the sdpr branch November 5, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants