Remove unused/deprecated AVConv_ classes #18666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
3.4 is not out yet, so unfortunately, this cannot be done until then. |
QuLogic
requested changes
Oct 5, 2020
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
Things deprecated in 3.3 cannot be removed until 3.5.
Contributor
Author
That's fair. Can I just leave the branch here until then? I notice that the circleCI tests are failing, anyway. |
Member
|
Sure, but you would need to fix the doc build before it is eventually merged. |
Member
|
Also, removals should get an API note. |
Member
|
I'm not clear how we resurface this whenever 3.5 comes out.... |
Contributor
|
By milestoning for 3.5? |
Member
|
Fair - I wasn't sure what our milestone guidelines were. |
Member
|
This can go in now, but it needs an API note. |
Member
|
Thanks for the PR, but this was complete in #20465. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Removes AVConvBase et al. and a related method in FFMpegBase that refers to a deprecated Ubuntu release. The deprecation warnings (which raise errors during tests) say that these classes will be removed by version 3.5, and they don't seem to be used by any other code in this version.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).