Skip to content

backend_pgf: clip paths within the backend (fixes #1857) - #1858

Merged
pelson merged 1 commit into
matplotlib:masterfrom
pwuertz:pgf_path_clip
Apr 18, 2013
Merged

pelson merged 1 commit into
matplotlib:masterfrom
pwuertz:pgf_path_clip

Conversation

@pwuertz

@pwuertz pwuertz commented Mar 26, 2013

Copy link
Copy Markdown
Contributor

Because LaTeX doesn't handle very large numbers (#1857), this PR moves some of the clipping operations from the pgf-code into backend_pgf.

@pwuertz

pwuertz commented Mar 27, 2013

Copy link
Copy Markdown
Contributor Author

Weird, python 2.6 and 3.x tests are passing on Travis, 2.7 is not (although it passes on my machine with 2.7). It also won't show me the log-file to see what's wrong :/

@mdboom

mdboom commented Mar 27, 2013

Copy link
Copy Markdown
Member

It looks like the Travis failure was a networking error when trying to install PIL, so in other words a false result. Looks like a reasonable fix to me.

Should this perhaps go on 1.2.x since it's a bugfix? Also, it could use a test -- I don't know if it needs to be an image comparison test, but something to just make sure the really large number doesn't show up in the output should be sufficient.

@pwuertz

pwuertz commented Mar 31, 2013

Copy link
Copy Markdown
Contributor Author

I just added a test that triggers #1857 and now passes with clipping added to draw_path.

Also, apparently some restructuring has been applied to master and a failed LaTeX call now results in an error looking up subprocess.CalledProcessError. I forwarded the missing Exception in matplotlib.compat.subprocess.

If this is fine with you we can apply this to master and I'll prepare another PR for 1.2 without the subprocess fix.

pelson added a commit that referenced this pull request Apr 18, 2013
backend_pgf: clip paths within the backend (fixes #1857)
@pelson
pelson merged commit 6e94330 into matplotlib:master Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants