Accept same types to errorevery as markevery#18556
Merged
Merged
Conversation
That argument is applied to the line, but errorbar masking is determined by *errorevery* (as actual masks), so *markevery* should not be propagated.
Though it doesn't accept real input for display-space, as errorbar is not continuous. Fixes matplotlib#4438.
QuLogic
added
New feature
API: consistency
timhoffm
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I did not add support for floating-point step sizes though, as errorbars are not continuous.
This also fixes a bug where passing
markeverywould crash, introduced in #17930, when the property dictionaries were changed around.I haven't implemented for 3D, but will do that with #18436.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).