Skip to content

backport pr 18549 #18550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jklymak merged 1 commit into from
Sep 23, 2020
Merged

backport pr 18549 #18550

jklymak merged 1 commit into from
Sep 23, 2020

Conversation

@jklymak
Copy link
Member

@jklymak jklymak commented Sep 23, 2020

Backport of #18549 to v3.3.x

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswell @jklymak
Merge pull request matplotlib#18549 from jklymak/fix-pcolorarg-conver…
3edd176 
…t-before-interp

FIX: unit-convert pcolorargs before interpolating
@jklymak jklymak added this to the v3.3.3 milestone Sep 23, 2020
@timhoffm
Copy link
Member

timhoffm commented Sep 23, 2020

Travis OSX failure is #18551 and should probably be cleared before merging.

@jklymak
Copy link
Member Author

jklymak commented Sep 23, 2020

I don't think there is anything here that is MacOS specific.

@timhoffm
Copy link
Member

timhoffm commented Sep 23, 2020 •
edited
Loading

If we are confident this doesn't make resolving #18551 harder, I'm ok to merge.

@jklymak
Copy link
Member Author

jklymak commented Sep 23, 2020

99.5% confident? I'll merge...

@jklymak jklymak merged commit 7247f21 into matplotlib:v3.3.x Sep 23, 2020
@jklymak jklymak deleted the auto-backport-of-pr-18549-on-v3.3.x branch September 23, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@jklymak @timhoffm @dopplershift @tacaswell