Skip to content

Warn if an animation is gc'd before doing anything. - #18445

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
QuLogic:warn-gc-anim
Sep 11, 2020
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
QuLogic:warn-gc-anim

Conversation

@QuLogic

@QuLogic QuLogic commented Sep 10, 2020

Copy link
Copy Markdown
Member

PR Summary

Wording may be a bit terse, feel free to make suggestions.

Fixes #18438.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.4.0 milestone Sep 10, 2020
Comment thread lib/matplotlib/animation.py Resolved
Comment thread lib/matplotlib/animation.py Resolved

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo @timhoffm 's suggestions.

Comment thread lib/matplotlib/tests/test_animation.py Resolved
@timhoffm
timhoffm merged commit f65d47e into matplotlib:master Sep 11, 2020
@QuLogic
QuLogic deleted the warn-gc-anim branch September 11, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn when a non-started animation is gc'ed.

3 participants