Unpin pydocstyle#18200
Closed
timhoffm wants to merge 2 commits into
Closed
Conversation
dopplershift
approved these changes
Aug 8, 2020
QuLogic
approved these changes
Aug 8, 2020
QuLogic
requested changes
Aug 8, 2020
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
No, actually, this crashed, but didn't exit with an error?
2020-08-08T00:32:34.0726903Z multiprocessing.pool.RemoteTraceback:
2020-08-08T00:32:34.0727442Z """
2020-08-08T00:32:34.0727740Z Traceback (most recent call last):
2020-08-08T00:32:34.0729039Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/multiprocessing/pool.py", line 125, in worker
2020-08-08T00:32:34.0729560Z result = (True, func(*args, **kwds))
2020-08-08T00:32:34.0730104Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/multiprocessing/pool.py", line 48, in mapstar
2020-08-08T00:32:34.0730427Z return list(map(*args))
2020-08-08T00:32:34.0731447Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/checker.py", line 655, in _run_checks
2020-08-08T00:32:34.0731775Z return checker.run_checks()
2020-08-08T00:32:34.0732673Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/checker.py", line 589, in run_checks
2020-08-08T00:32:34.0733040Z self.run_ast_checks()
2020-08-08T00:32:34.0733646Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/checker.py", line 496, in run_ast_checks
2020-08-08T00:32:34.0733978Z for (line_number, offset, text, _) in runner:
2020-08-08T00:32:34.0734557Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8_docstrings.py", line 131, in run
2020-08-08T00:32:34.0734904Z for error in self._check_source():
2020-08-08T00:32:34.0735499Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8_docstrings.py", line 112, in _check_source
2020-08-08T00:32:34.0735879Z for err in self.checker.check_source(
2020-08-08T00:32:34.0736492Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/pydocstyle/checker.py", line 123, in check_source
2020-08-08T00:32:34.0736835Z for error in errors:
2020-08-08T00:32:34.0737458Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/pydocstyle/checker.py", line 915, in check_docstring_sections
2020-08-08T00:32:34.0737823Z found_numpy = yield from self._check_numpy_sections(lines, definition, docstring)
2020-08-08T00:32:34.0738607Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/pydocstyle/checker.py", line 879, in _check_numpy_sections
2020-08-08T00:32:34.0738968Z yield from self._check_numpy_section(docstring, definition, ctx)
2020-08-08T00:32:34.0739604Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/pydocstyle/checker.py", line 693, in _check_numpy_section
2020-08-08T00:32:34.0739947Z yield from cls._check_parameters_section(docstring, definition, context)
2020-08-08T00:32:34.0740617Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/pydocstyle/checker.py", line 731, in _check_parameters_section
2020-08-08T00:32:34.0740968Z yield from ConventionChecker._check_missing_args(docstring_args, definition)
2020-08-08T00:32:34.0741579Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/pydocstyle/checker.py", line 762, in _check_missing_args
2020-08-08T00:32:34.0741938Z function_args = get_function_args(definition.source)
2020-08-08T00:32:34.0742548Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/pydocstyle/checker.py", line 1002, in get_function_args
2020-08-08T00:32:34.0742888Z function_arg_node = ast.parse(textwrap.dedent(function_string)).body[0].args
2020-08-08T00:32:34.0743403Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/ast.py", line 47, in parse
2020-08-08T00:32:34.0743724Z return compile(source, filename, mode, flags,
2020-08-08T00:32:34.0744052Z File "<unknown>", line 1
2020-08-08T00:32:34.0744329Z def quiver(self, *args,
2020-08-08T00:32:34.0744620Z ^
2020-08-08T00:32:34.0744884Z IndentationError: unexpected indent
2020-08-08T00:32:34.0745160Z """
2020-08-08T00:32:34.0745330Z
2020-08-08T00:32:34.0745612Z The above exception was the direct cause of the following exception:
2020-08-08T00:32:34.0745843Z
2020-08-08T00:32:34.0746106Z Traceback (most recent call last):
2020-08-08T00:32:34.0746460Z File "/opt/hostedtoolcache/Python/3.8.5/x64/bin/flake8", line 8, in <module>
2020-08-08T00:32:34.0746784Z sys.exit(main())
2020-08-08T00:32:34.0747385Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/main/cli.py", line 22, in main
2020-08-08T00:32:34.0747712Z app.run(argv)
2020-08-08T00:32:34.0748301Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/main/application.py", line 360, in run
2020-08-08T00:32:34.0748632Z self._run(argv)
2020-08-08T00:32:34.0749209Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/main/application.py", line 348, in _run
2020-08-08T00:32:34.0749535Z self.run_checks()
2020-08-08T00:32:34.0750279Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/main/application.py", line 262, in run_checks
2020-08-08T00:32:34.0750670Z self.file_checker_manager.run()
2020-08-08T00:32:34.0751244Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/checker.py", line 323, in run
2020-08-08T00:32:34.0751565Z self.run_parallel()
2020-08-08T00:32:34.0752145Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/flake8/checker.py", line 289, in run_parallel
2020-08-08T00:32:34.0752469Z for ret in pool_map:
2020-08-08T00:32:34.0752937Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/multiprocessing/pool.py", line 448, in <genexpr>
2020-08-08T00:32:34.0754871Z return (item for chunk in result for item in chunk)
2020-08-08T00:32:34.0755114Z File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/multiprocessing/pool.py", line 868, in next
2020-08-08T00:32:34.0755268Z raise value
2020-08-08T00:32:34.0755464Z File "<unknown>", line 1
2020-08-08T00:32:34.0755629Z def quiver(self, *args,
2020-08-08T00:32:34.0755831Z ^
2020-08-08T00:32:34.0755995Z IndentationError: unexpected indent
Member
|
Ah, I know, we need to set bash to pipefail, so it errors if any part of the pipe fails. |
1 task
dstansby
requested changes
Aug 16, 2020
dstansby
left a comment
dstansby
left a comment
Member
There was a problem hiding this comment.
This now needs a rebase to see if the tests pass.
timhoffm
force-pushed
the
unpin-pydocstyle
branch
from
f9b3510 to
95a8d67
Compare
Member
Author
|
rebased. |
Member
Author
|
Pydocstyle seems to be more picky and partly even incorrect in the reported messages. Needs more investigation. |
timhoffm
force-pushed
the
unpin-pydocstyle
branch
2 times, most recently
from
7952aab to
31b2d19
Compare
timhoffm
force-pushed
the
unpin-pydocstyle
branch
from
31b2d19 to
26293f7
Compare
2 tasks
Member
Author
|
Superseded by #18780 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Undo #14710.
The incompatibility has been resolved in flake8-docstring v1.3.1 (https://pypi.org/project/flake8-docstrings/).
Let's see if CI agrees.