Fix nbagg in Chrome 84 #18142
Merged
Fix nbagg in Chrome 84 #18142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ResizeObserver spec changed, though Firefox still does the old way. Previous Chrome implemented an even older version, and 84 implements the latest version, but not this in-between one we're using.
This is only implemented on Chrome, but prevents some blurriness.
QuLogic
added
the
Release critical
jkseppan
approved these changes
Aug 2, 2020
Member
jkseppan
left a comment
jkseppan
left a comment
There was a problem hiding this comment.
Looks good to me, although I don't know the details of all the specs. I trust that you tested this with the browsers mentioned in comments.
jklymak
approved these changes
Aug 2, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 2, 2020
dopplershift
added a commit
that referenced
this pull request
Aug 2, 2020
…142-on-v3.3.x Backport PR #18142 on branch v3.3.x (Fix nbagg in Chrome 84)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We check attributes for Firefox, and old Chrome. Chrome 84 implements a new version of the
ResizeObserverspec, which uses the same attribute names as Firefox, but a different type. Naturally, JS doesn't complain and just returns undefined...Also, fix the menu showing up on right-click.
Fixes #18132.
PR Checklist