Skip to content

ci: Fix linting being ignored by reviewdog #18091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dopplershift merged 3 commits into from
Jul 28, 2020
Merged

ci: Fix linting being ignored by reviewdog #18091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12bef74
ci: Add tee to debug reviewdog.
QuLogic Jul 28, 2020
0c4a0d2
ci: Disable filtering of lint errors.
QuLogic Jul 28, 2020
3eb4779
Fix flake8 issues.
QuLogic Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ jobs:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
flake8 --docstring-convention=all | \
reviewdog -f=pep8 -name=flake8 -reporter=github-check
reviewdog -f=pep8 -name=flake8 \
-tee -reporter=github-check -filter-mode nofilter

eslint:
name: eslint
Expand All @@ -40,6 +41,7 @@ jobs:
- name: eslint
uses: reviewdog/action-eslint@v1
with:
filter_mode: nofilter
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-check
workdir: 'lib/matplotlib/backends/web_backend/'
8 changes: 4 additions & 4 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,8 +830,8 @@ def axhline(self, y=0, xmin=0, xmax=1, **kwargs):
"""
self._check_no_units([xmin, xmax], ['xmin', 'xmax'])
if "transform" in kwargs:
raise ValueError("'transform' is not allowed as a keyword argument; "
"axhline generates its own transform.")
raise ValueError("'transform' is not allowed as a keyword "
"argument; axhline generates its own transform.")
ymin, ymax = self.get_ybound()

# We need to strip away the units for comparison with
Expand Down Expand Up @@ -899,8 +899,8 @@ def axvline(self, x=0, ymin=0, ymax=1, **kwargs):
"""
self._check_no_units([ymin, ymax], ['ymin', 'ymax'])
if "transform" in kwargs:
raise ValueError("'transform' is not allowed as a keyword argument; "
"axvline generates its own transform.")
raise ValueError("'transform' is not allowed as a keyword "
"argument; axvline generates its own transform.")
xmin, xmax = self.get_xbound()

# We need to strip away the units for comparison with
Expand Down
1 change: 0 additions & 1 deletion lib/matplotlib/rcsetup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import logging
from numbers import Number
import operator
import os
import re

import numpy as np
Expand Down