Skip to content

Make inset_axes and secondary_axis picklable.#17993

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:pis
Jul 21, 2020
Merged

Make inset_axes and secondary_axis picklable.#17993
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:pis

Conversation

@anntzer

@anntzer anntzer commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

... by making the locator a class, instead of a nested function.
Also, reuse the inset_locator machinery in secondary_axis, instead of
duplicating it there.

Supersedes #17249, which only unduplicated secondary/inset (or I can rebase on top of it after it gets merged).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

... by making the locator a class, instead of a nested function.
Also, reuse the inset_locator machinery in secondary_axis, instead of
duplicating it there.
@jklymak jklymak added this to the v3.4.0 milestone Jul 21, 2020
@tacaswell tacaswell merged commit 37cb671 into matplotlib:master Jul 21, 2020
@anntzer anntzer deleted the pis branch July 22, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants