Skip to content

Fix for #1792 - #1794

Merged
mdboom merged 2 commits into
matplotlib:masterfrom
astrofrog:fix-pyparsing-requirement
Feb 27, 2013
Merged

mdboom merged 2 commits into
matplotlib:masterfrom
astrofrog:fix-pyparsing-requirement

Conversation

@astrofrog

Copy link
Copy Markdown
Contributor

As of pyparsing 2.0.0, Python 2 is no longer supported, so we need to set an upper limit for the range of versions installable by pip.

… set an upper limit for the range of versions installable by pip
Comment thread setupext.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future proofing should this not be 2.0.0?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you mean strictly less than 2.0.0?

@astrofrog

Copy link
Copy Markdown
Contributor Author

@pelson - I fixed the version requirement to make it future proof, on the assumption that the 1.x branch of pyparsing will always remain Python 2 compatible.

@astrofrog

Copy link
Copy Markdown
Contributor Author

@pelson - it looks like Travis passed, so feel free to merge if you are happy with it.

@mdboom

mdboom commented Feb 27, 2013

Copy link
Copy Markdown
Member

Yeah -- I had thought pip would handle the Python version difference, but apparently not. I think this is the correct fix.

@mdboom

mdboom commented Feb 27, 2013

Copy link
Copy Markdown
Member

Also see the tangentially related #1788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants