Skip to content

Fix Axes3D.add_collection3d issues - #17851

Merged
QuLogic merged 5 commits into
matplotlib:masterfrom
thangleiter:fix_add_collection3d_issues
Aug 10, 2020
Merged

QuLogic merged 5 commits into
matplotlib:masterfrom
thangleiter:fix_add_collection3d_issues

Conversation

@thangleiter

@thangleiter thangleiter commented Jul 7, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

This PR fixes the following bugs in Axes3D.add_collection3d (#17755):

  • Axes3D.add_collection3d cannot deal with line segments instead of points for the zs parameter.
  • Axes3D.add_collection3d does not return the Line3DCollection object, thus one cannot for example add a colorbar.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.4.0 milestone Jul 7, 2020
Comment thread lib/mpl_toolkits/mplot3d/art3d.py Resolved
Comment thread lib/mpl_toolkits/tests/test_mplot3d.py Resolved
Comment thread lib/mpl_toolkits/tests/test_mplot3d.py Resolved
thangleiter and others added 2 commits August 8, 2020 18:52
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic
QuLogic merged commit 647a966 into matplotlib:master Aug 10, 2020
@QuLogic

QuLogic commented Aug 10, 2020

Copy link
Copy Markdown
Member

Thanks @thangleiter! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants