Repository navigation
Fix Axes3D.add_collection3d issues - #17851
Merged
QuLogic merged 5 commits intoAug 10, 2020
Merged
Conversation
QuLogic
reviewed
Jul 11, 2020
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
dopplershift
approved these changes
Aug 8, 2020
QuLogic
approved these changes
Aug 10, 2020
Member
|
Thanks @thangleiter! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes the following bugs in
Axes3D.add_collection3d(#17755):Axes3D.add_collection3dcannot deal with line segments instead of points for thezsparameter.Axes3D.add_collection3ddoes not return theLine3DCollectionobject, thus one cannot for example add a colorbar.PR Checklist