Repository navigation
Improve categorical converter error message - #17824
Merged
Merged
Conversation
Member
|
It's slightly more specific than an |
2 of 3 tasks
Contributor
|
I agree the error message should be something more actionable e.g. "not a valid categorical unit" or similar |
Member
Author
|
How about now? I think this is a small improvement avoids the user having to work out where and why the attribute error was thrown, immediately saying "the problem was with the unit passed to a categorical converter". |
tacaswell
approved these changes
Jul 3, 2020
QuLogic
reviewed
Jul 3, 2020
efiring
approved these changes
Jul 4, 2020
story645
approved these changes
Jul 5, 2020
story645
left a comment
story645
left a comment
Member
There was a problem hiding this comment.
Slightly concerned since ._mapping is a private attribute so I don't quite know what users can do to fix this error.
Member
|
It is at least a less-confusing error message that the type error (for the same private attribute) that they are getting now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
xref #11095. Provide a nicer error message if the user tries to set a
unitwithout_mappingto a categorical converter.PR Checklist