More qt fractional DPI fixes - #17640
Merged
Merged
Conversation
6 tasks
tacaswell
approved these changes
Jun 15, 2020
Member
import matplotlib.pyplot as plt
import numpy as np
th = np.linspace(0, 2*np.pi, 512)
fig, ax = plt.subplots()
ax.plot(th, np.sin(th))
ax.plot(th, np.cos(th))
ax.set_title(fig.canvas._dpi_ratio)
plt.show()Each of those was launched with ✔ 19:57:24 $ with ${...}.swap(QT_SCALE_FACTOR=2.0):
............ python /tmp/tester.py &
............ There is no visual difference between this branch and master. |
Merged
Member
Author
|
From what we've seen, I think that should be correct. At least, it seems like |
story645
approved these changes
Jun 16, 2020
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Jun 16, 2020
Merge pull request matplotlib#17640 from QuLogic/more-pyqt5-fixes More qt fractional DPI fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
Followup to #15656.
PR Checklist