Repository navigation
Search for minus of any font size to get height of tex result - #17578
Merged
Merged
Conversation
When searching for minus symbols in tex output, to treat them as a special case, do so for any font size not just font size 10. Minus is glyph zero of the font cmsyXX (XX being the font size).
timhoffm
approved these changes
Jun 5, 2020
QuLogic
reviewed
Jun 6, 2020
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Member
|
This looks good, but can you update the test ( |
QuLogic
approved these changes
Aug 4, 2020
Member
|
Thanks @adambrown1! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When searching for minus symbols in tex output, to treat them as a special case, do so for any font size not just font size 10. Minus is glyph zero of the font cmsyXX (XX being the font size).
This ensures that negative numbers have correct alignment when using tex, whatever the font size being used. This closes #17574.
The same example in the issue now gives the correct output:
PR Checklist